Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add getBounds() method for BrowserView #19370

Merged
merged 4 commits into from
Jul 30, 2019
Merged

feat: add getBounds() method for BrowserView #19370

merged 4 commits into from
Jul 30, 2019

Conversation

deermichel
Copy link
Contributor

Description of Change

Closes #18734.

This PR extends the functionality of our experimental BrowserView API by adding a getBounds() method to get the current size & position.

cc @codebytere @erickzhao

Checklist

Release Notes

Notes: Added getBounds() method for BrowserView.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 22, 2019
@deermichel deermichel force-pushed the intern/webview-getbounds branch from 69b1aa9 to fd71541 Compare July 22, 2019 20:10
@codebytere codebytere changed the title feat: add getBounds() method for BrowserView feat: add getBounds() method for BrowserView Jul 22, 2019
@codebytere codebytere added the semver/minor backwards-compatible functionality label Jul 22, 2019
codebytere
codebytere approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The impl looks good here, but i'd also like to see a test verifying that the result returned by view.getBounds() changes appropriately when called after view.setBounds(bounds) before we merge.

docs/api/browser-view.md Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 23, 2019
@deermichel deermichel force-pushed the intern/webview-getbounds branch from fd71541 to d354056 Compare July 24, 2019 00:38
@deermichel deermichel mentioned this pull request Jul 24, 2019
Merged
3 tasks
@codebytere
Copy link
Member

@deermichel once the conflicts are resolved this should be good to go :)

@deermichel deermichel force-pushed the intern/webview-getbounds branch from d354056 to 5ac40d3 Compare July 25, 2019 20:52
@codebytere codebytere merged commit 42a483a into master Jul 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 30, 2019

Release Notes Persisted

Added getBounds() method for BrowserView.

@codebytere codebytere deleted the intern/webview-getbounds branch July 30, 2019 02:43
@rlingineni
Copy link

@codebytere - did this ship yet?

@deermichel
Copy link
Contributor Author

It will ship with Electron v7 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getBounds for BrowserView like BrowserWindow
3 participants
@deermichel @codebytere @rlingineni