Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getBounds() method for BrowserView #19370

Merged
merged 4 commits into from Jul 30, 2019

Conversation

@deermichel
Copy link

deermichel commented Jul 22, 2019

Description of Change

Closes #18734.

This PR extends the functionality of our experimental BrowserView API by adding a getBounds() method to get the current size & position.

cc @codebytere @erickzhao

Checklist

Release Notes

Notes: Added getBounds() method for BrowserView.

@deermichel deermichel force-pushed the intern/webview-getbounds branch from 69b1aa9 to fd71541 Jul 22, 2019
@codebytere codebytere changed the title feat: add `getBounds()` method for BrowserView feat: add getBounds() method for BrowserView Jul 22, 2019
Copy link
Member

codebytere left a comment

The impl looks good here, but i'd also like to see a test verifying that the result returned by view.getBounds() changes appropriately when called after view.setBounds(bounds) before we merge.

docs/api/browser-view.md Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 label Jul 23, 2019
@deermichel deermichel force-pushed the intern/webview-getbounds branch from fd71541 to d354056 Jul 24, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Jul 25, 2019

@deermichel once the conflicts are resolved this should be good to go :)

@deermichel deermichel force-pushed the intern/webview-getbounds branch from d354056 to 5ac40d3 Jul 25, 2019
@codebytere codebytere merged commit 42a483a into master Jul 30, 2019
13 checks passed
13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190725.40 succeeded
Details
electron-arm64-testing Build #20190725.40 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 30, 2019

Release Notes Persisted

Added getBounds() method for BrowserView.

@codebytere codebytere deleted the intern/webview-getbounds branch Jul 30, 2019
@rlingineni

This comment has been minimized.

Copy link

rlingineni commented Oct 8, 2019

@codebytere - did this ship yet?

@deermichel

This comment has been minimized.

Copy link
Author

deermichel commented Oct 8, 2019

It will ship with Electron v7 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.