Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle edge behavior for about panel on Linux #19625

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 5, 2019

Backport of #19586

See that PR for details.

Notes: Fixed bug where app would crash if app.showAboutPanel() was called before setting any About panel options on Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2019
@trop trop bot added 7-0-x backport This is a backport PR labels Aug 5, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2019
@codebytere codebytere merged commit 0afb1a8 into 7-0-x Aug 6, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 6, 2019

Release Notes Persisted

Fixed bug where app would crash if app.showAboutPanel() was called before setting any About panel options on Linux.

@codebytere codebytere deleted the trop/7-0-x-bp-fix-handle-edge-behavior-for-about-panel-on-linux-1565016832692 branch August 6, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants