Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't handle browser messages before document element is created (6-0-x) #19719

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@zcbenz
Copy link
Member

commented Aug 12, 2019

Backport of #19718.

Notes: Fix async Node APIs not working after received IPC message.

zcbenz added some commits Aug 12, 2019

fix: bind ElectronApiServiceImpl later
DidCreateDocumentElement is called before the ElectronApiServiceImpl
gets bound.

@MarshallOfSound MarshallOfSound merged commit 98d78f2 into 6-0-x Aug 12, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190812.15 succeeded
Details
electron-arm64-testing Build #20190812.14 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 12, 2019

Release Notes Persisted

Fix async Node APIs not working after received IPC message.

@MarshallOfSound MarshallOfSound deleted the fix-ipc-node-block-6-0-x branch Aug 12, 2019

@l7s

This comment has been minimized.

Copy link

commented Aug 13, 2019

Do we still need this commit c0e9761 or perhaps now we have a proper fix and it should be reverted?

@zcbenz

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

I think it is no longer needed, will start a PR to revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.