Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default media usage strings to info.plist #19949

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@codebytere
Copy link
Member

commented Aug 26, 2019

Backport of #19871

Notes: Added default NSMicrophoneUsageDescription and NSCameraUsageDescription strings to info.plist.

@codebytere codebytere requested a review from MarshallOfSound Aug 26, 2019

@trop trop bot referenced this pull request Aug 26, 2019
4 of 4 tasks complete

@codebytere codebytere requested a review from electron/wg-releases Aug 26, 2019

@MarshallOfSound MarshallOfSound merged commit b52a2ae into 6-0-x Aug 27, 2019

13 of 14 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190826.34 succeeded
Details
electron-arm64-testing Build #20190826.35 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 27, 2019

Release Notes Persisted

Added default NSMicrophoneUsageDescription and NSCameraUsageDescription strings to info.plist.

@MarshallOfSound MarshallOfSound deleted the media-usage-6 branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.