Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webRequest should be able to modify CORS headers (7-1-x) #21123

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@zcbenz
Copy link
Member

zcbenz commented Nov 14, 2019

Backport of #21099.

Notes: Fix webRequest module unable to modify CORS headers.

@zcbenz zcbenz requested a review from deepak1556 Nov 14, 2019
@trop trop bot mentioned this pull request Nov 14, 2019
5 of 6 tasks complete
@trop trop bot added 7-1-x backport labels Nov 14, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Nov 14, 2019
@zcbenz zcbenz force-pushed the protocol-extra-headers-7-1-x branch 3 times, most recently from 2a3311c to ea3f76c Nov 14, 2019
@zcbenz zcbenz removed the request for review from deepak1556 Nov 14, 2019
@zcbenz zcbenz added the wip label Nov 14, 2019
@zcbenz

This comment has been minimized.

Copy link
Member Author

zcbenz commented Nov 14, 2019

The fix somehow does not work for 7.x, I will look into it later.

@zcbenz zcbenz force-pushed the protocol-extra-headers-7-1-x branch from ea3f76c to 6ee79fc Nov 15, 2019
@zcbenz

This comment has been minimized.

Copy link
Member Author

zcbenz commented Nov 15, 2019

It turns out the added tests have to run in main process because of remote's limitation, I have also backported #19992 (test: move webRequest spec to main runner) to fix the failing tests.

@zcbenz zcbenz requested a review from electron/wg-releases Nov 15, 2019
@deepak1556 deepak1556 removed the wip label Nov 15, 2019
@zcbenz zcbenz merged commit 49d91c7 into 7-1-x Nov 15, 2019
16 checks passed
16 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191115.1 succeeded
Details
electron-arm64-testing Build #20191115.1 succeeded
Details
electron-woa-testing Build #20191115.2 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 15, 2019

Release Notes Persisted

Fix webRequest module unable to modify CORS headers.

@zcbenz zcbenz deleted the protocol-extra-headers-7-1-x branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.