Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webRequest should be able to modify CORS headers (7-1-x) #21123

Merged
merged 2 commits into from
Nov 15, 2019
Merged

fix: webRequest should be able to modify CORS headers (7-1-x) #21123

merged 2 commits into from
Nov 15, 2019

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Nov 14, 2019

Backport of #21099.

Notes: Fix webRequest module unable to modify CORS headers.

@zcbenz zcbenz requested a review from deepak1556 November 14, 2019 06:22
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 14, 2019
@trop trop bot mentioned this pull request Nov 14, 2019
Merged
6 tasks
@trop trop bot added 7-1-x backport This is a backport PR labels Nov 14, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 14, 2019
@zcbenz zcbenz force-pushed the protocol-extra-headers-7-1-x branch 3 times, most recently from 2a3311c to ea3f76c Compare November 14, 2019 12:34
@zcbenz zcbenz removed the request for review from deepak1556 November 14, 2019 14:06
@zcbenz zcbenz added the wip ⚒ label Nov 14, 2019
@zcbenz
Copy link
Contributor Author

zcbenz commented Nov 14, 2019

The fix somehow does not work for 7.x, I will look into it later.

@zcbenz zcbenz force-pushed the protocol-extra-headers-7-1-x branch from ea3f76c to 6ee79fc Compare November 15, 2019 00:27
@zcbenz
Copy link
Contributor Author

zcbenz commented Nov 15, 2019

It turns out the added tests have to run in main process because of remote's limitation, I have also backported #19992 (test: move webRequest spec to main runner) to fix the failing tests.

@zcbenz zcbenz requested a review from a team November 15, 2019 01:13
@zcbenz zcbenz merged commit 49d91c7 into 7-1-x Nov 15, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 15, 2019

Release Notes Persisted

Fix webRequest module unable to modify CORS headers.

@zcbenz zcbenz deleted the protocol-extra-headers-7-1-x branch November 15, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcbenz @deepak1556 @nornagon