Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update online-offline-events.md to reflect nodeIntegration required #21707

Merged
merged 2 commits into from
Jan 13, 2020

Conversation

daveilers
Copy link
Contributor

@daveilers daveilers commented Jan 8, 2020

NodeIntegration is required for online/offline and the default changed in 5.0.0, so the example should reflect the need for that config

Description of Change

Checklist

Release Notes

Notes: no notes

NodeIntegration is required for online/offline and the default changed, so the example should reflect the need for that config
@welcome
Copy link

welcome bot commented Jan 8, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 8, 2020
@daveilers daveilers changed the title Update online-offline-events.md Docs: Update online-offline-events.md to reflect nodeIntegration required Jan 8, 2020
@daveilers daveilers changed the title Docs: Update online-offline-events.md to reflect nodeIntegration required docs: Update online-offline-events.md to reflect nodeIntegration required Jan 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 9, 2020
@zcbenz zcbenz merged commit 2f394d4 into electron:master Jan 13, 2020
@welcome
Copy link

welcome bot commented Jan 13, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jan 13, 2020

Release Notes Persisted

no notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants