Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore (un)lock events for sessions that aren't the current session #21805

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fix: ignore (un)lock events for sessions that aren't the current session #21805

merged 1 commit into from
Jan 20, 2020

Conversation

MarshallOfSound
Copy link
Member

Citrix and MS Remote Desktop send session changed notifications to all users on a machine, apparently.

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1929489

Notes: Fixed case where unlock-screen and lock-screen events would fire erroneously on citrix and other multi-session systems.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 16, 2020
felixrieseberg
felixrieseberg approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 'cause it's the same code as Chrome, looks solid.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 17, 2020
@zcbenz zcbenz merged commit ebe8bdd into master Jan 20, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 20, 2020

Release Notes Persisted

Fixed case where unlock-screen and lock-screen events would fire erroneously on citrix and other multi-session systems.

@zcbenz zcbenz deleted the check-session-id-in-lock-events branch January 20, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@felixrieseberg felixrieseberg felixrieseberg approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarshallOfSound @zcbenz @deepak1556 @felixrieseberg @codebytere