fix: crash on custom printing margins #22187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
codebytere
changed the title
|
Build is failing due to API changes of |
codebytere
force-pushed
the
printing-margins-bp-7
branch
3 times, most recently
from
bb8ec94 to
c8b7bd0
Compare
codebytere
force-pushed
the
printing-margins-bp-7
branch
from
c8b7bd0 to
0edac85
Compare
zcbenz
approved these changes
Feb 17, 2020
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #22164.
See that PR for details.
Notes: Fixed a crash in
webContents.print()with custom print margins.