fix: don't try to hide host which has set flag disable_hidden_ #22852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
6 tasks
ckerr
approved these changes
Mar 26, 2020
zcbenz
approved these changes
Mar 27, 2020
Lack of this change will lead to freeze after call to hide/show on window which has set flag disable_hidden_. To reproduce the problem it's necessary to create some number of windows (how many it depends on number of windows being cached by Chromium's FrameEvictionManager).
zcbenz
force-pushed
the
trop/9-x-y-bp-fix-don-t-try-to-hide-host-which-has-set-flag-disable_hidden_-1585252465057
branch
from
47cfe5c to
894f539
Compare
|
Force pushed to fix pending lint task. This still requires an approval from @electron/wg-upgrades. |
deepak1556
approved these changes
Mar 27, 2020
|
Release Notes Persisted
|
codebytere
deleted the
trop/9-x-y-bp-fix-don-t-try-to-hide-host-which-has-set-flag-disable_hidden_-1585252465057
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #22832
See that PR for details.
Notes: fixed possible freeze on window with disabled background throttling