Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webRequest module should work with file:// protocol (9-x-y) #22919

Merged
merged 2 commits into from
Apr 1, 2020
Merged

fix: webRequest module should work with file:// protocol (9-x-y) #22919

merged 2 commits into from
Apr 1, 2020

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Apr 1, 2020

Backport of #22903.

Notes: Fix webRequest module not working with file:// protocol.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 1, 2020
@trop trop bot mentioned this pull request Apr 1, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 1, 2020
@zcbenz zcbenz requested a review from deepak1556 April 1, 2020 08:57
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 1, 2020
@zcbenz zcbenz force-pushed the webrequest-with-file-url-9-x-y branch from f896008 to 9fc5064 Compare April 1, 2020 10:58
@deepak1556
Copy link
Member

Failing test is unrelated, merging.

@deepak1556 deepak1556 merged commit f255d47 into 9-x-y Apr 1, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 1, 2020

Release Notes Persisted

Fix webRequest module not working with file:// protocol.

@deepak1556 deepak1556 deleted the webrequest-with-file-url-9-x-y branch April 1, 2020 20:36
@nornagon nornagon mentioned this pull request Apr 1, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @deepak1556