Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick 2aac556145af from v8 #23059

Merged
merged 3 commits into from Apr 13, 2020
Merged

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Apr 9, 2020

Make CreateDynamicFunction throw if disallowed

... instead of returning undefined.

Bug: chromium:1065094
Change-Id: I0b0397a8affd44b58e7f4777f32ba22bbd001ab1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124837
Reviewed-by: Toon Verwaest verwaest@chromium.org
Commit-Queue: Georg Neis neis@chromium.org
Cr-Commit-Position: refs/heads/master@{#66902}

Notes: Security: backported a fix for crbug.com/1065094.

Copy link
Contributor

@jkleinsc jkleinsc left a comment

Seems reasonable.

@nornagon nornagon merged commit 4dc2c28 into 7-2-x Apr 13, 2020
15 of 16 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 13, 2020

Release Notes Persisted

Security: backported a fix for crbug.com/1065094.

@nornagon nornagon deleted the cherry-pick/7-2-x/v8/2aac556145af branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants