fix: missing handlescopes in event emission #23140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
suggested changes
Apr 16, 2020
deepak1556
requested changes
Apr 16, 2020
codebytere
force-pushed
the
fix-tray-click-handlescope
branch
from
8e4e7d0 to
1b6e70c
Compare
codebytere
changed the title
deepak1556
approved these changes
Apr 16, 2020
zcbenz
reviewed
Apr 17, 2020
codebytere
force-pushed
the
fix-tray-click-handlescope
branch
2 times, most recently
from
2fe7601 to
01450e3
Compare
codebytere
force-pushed
the
fix-tray-click-handlescope
branch
from
01450e3 to
7ab0ef0
Compare
zcbenz
approved these changes
Apr 24, 2020
nornagon
approved these changes
Apr 27, 2020
codebytere
force-pushed
the
fix-tray-click-handlescope
branch
from
7ab0ef0 to
cd77350
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #23139.
Fixes crashes in
CreateEventFromFlagsandEmitCustomEventowing to missingHandleScopes.cc @deepak1556 @zcbenz @nornagon
Checklist
npm testpassesRelease Notes
Notes: Fixed some event listener crashes in Tray.