Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compensate for lazy-loaded circular deps #23951

Merged
merged 1 commit into from
Jun 3, 2020
Merged

fix: compensate for lazy-loaded circular deps #23951

merged 1 commit into from
Jun 3, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 3, 2020

Backport of #23890

See that PR for details.

Notes: Fixed an issue where rmdir and rmdirSync work with original-fs in an asar context.

@trop trop bot requested a review from a team as a code owner June 3, 2020 17:29
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020
@trop trop bot requested a review from codebytere June 3, 2020 17:29
@trop trop bot mentioned this pull request Jun 3, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Jun 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020
@jkleinsc jkleinsc merged commit 3087492 into 10-x-y Jun 3, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 3, 2020

Release Notes Persisted

Fixed an issue where rmdir and rmdirSync work with original-fs in an asar context.

@jkleinsc jkleinsc deleted the trop/10-x-y-bp-fix-compensate-for-lazy-loaded-circular-deps-1591205372642 branch June 3, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @codebytere