Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve the REPL #24204

Merged
merged 2 commits into from
Jun 23, 2020
Merged

refactor: improve the REPL #24204

merged 2 commits into from
Jun 23, 2020

Conversation

codebytere
Copy link
Member

Description of Change

This PR improves the Electron REPL experience. It adds a welcome message to the REPL to let users know what versions of Node.js and Electron they're running, as well as overriding the completer function in the REPL to preload and add tab autocompletion for Electron's own modules.

Screen Shot 2020-06-18 at 10 27 15 PM

cc @MarshallOfSound

Checklist

Release Notes

Notes: Improved the default REPL experience when running Electron with the --interactive flag.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 19, 2020
@codebytere codebytere force-pushed the better-repl branch 4 times, most recently from 81887fb to 35ee3e3 Compare June 19, 2020 14:49
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 20, 2020
@codebytere codebytere requested review from ckerr and jkleinsc June 22, 2020 19:04
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but might want to reconsider use of redish/green colors for accessibility.

default_app/main.ts Outdated Show resolved Hide resolved
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

@codebytere codebytere merged commit 4c77fe3 into master Jun 23, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 23, 2020

Release Notes Persisted

Improved the default REPL experience when running Electron with the --interactive flag.

@codebytere codebytere deleted the better-repl branch June 23, 2020 02:03
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
This PR improves the Electron REPL experience. It adds a welcome message to the REPL to let users know what versions of Node.js and Electron they're running, as well as overriding the completer function in the REPL to preload and add tab autocompletion for Electron's own modules.
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
This PR improves the Electron REPL experience. It adds a welcome message to the REPL to let users know what versions of Node.js and Electron they're running, as well as overriding the completer function in the REPL to preload and add tab autocompletion for Electron's own modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants