Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MessagePorts in the main process #24323

merged 1 commit into from Jul 2, 2020


Copy link

@miniak miniak commented Jun 26, 2020

Backport of #22404

Notes: Added support for MessagePort in the main process.

@miniak miniak requested a review from a team as a code owner June 26, 2020 19:34
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2020
@trop trop bot mentioned this pull request Jun 26, 2020
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 26, 2020
@miniak miniak self-assigned this Jun 26, 2020
Copy link

Just noting here but will also discuss at the WG meeting, IMO this is far too big / untested to backport into a minor release at this time

Copy link

I think the risk here is relatively low as there's not much code changed when not using MessagePort. The only diff here is that the serialize/deserialize functions got moved into a new file. haven't gone over them to check for potential differences / issues, but that's the only area of concern i have re: breaking existing apps.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 27, 2020
Copy link

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Release WG

@nornagon nornagon merged commit 4ace499 into 9-x-y Jul 2, 2020
1 check passed
Copy link

release-clerk bot commented Jul 2, 2020

Release Notes Persisted

Added support for MessagePort in the main process.

@nornagon nornagon deleted the miniak/message-ports-9-x-y branch July 2, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants