Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uv_walk crash on web worker close #24462

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 8, 2020

Backport of #24436

See that PR for details.

Notes: Fixed a termination crash on Web Workers with Node.js integration enabled.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 8, 2020
@trop trop bot requested a review from codebytere July 8, 2020 18:01
@trop trop bot mentioned this pull request Jul 8, 2020
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Jul 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 8, 2020
@codebytere
Copy link
Member

Failure:

chromium features PDF Viewer opens when loading a pdf resource as top level navigation

is unrelated - merging.

@codebytere codebytere merged commit 3283211 into 10-x-y Jul 8, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 8, 2020

Release Notes Persisted

Fixed a termination crash on Web Workers with Node.js integration enabled.

@codebytere codebytere deleted the trop/10-x-y-bp-fix-uv_walk-crash-on-web-worker-close-1594231261527 branch July 8, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant