Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken --trace-sync-io flag in Node.js #24529

Merged
merged 2 commits into from
Jul 14, 2020
Merged

fix: broken --trace-sync-io flag in Node.js #24529

merged 2 commits into from
Jul 14, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Fixes broken --trace-sync-io flag in Node.js resultant of us not properly setting it in our embedded logic.

cc @nornagon @MarshallOfSound @jkleinsc

Checklist

Release Notes

Notes: Fixed broken --trace-sync-io flag in Node.js.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2020
MarshallOfSound
MarshallOfSound reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can / should we do this for non run-as node as well?

jkleinsc
jkleinsc approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2020
@codebytere codebytere merged commit ce87a7e into master Jul 14, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 14, 2020

Release Notes Persisted

Fixed broken --trace-sync-io flag in Node.js.

@codebytere codebytere deleted the fix-trace-sync-io branch July 14, 2020 17:47
@trop
Copy link
Contributor

trop bot commented Jul 14, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Jul 14, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jul 14, 2020

I have automatically backported this PR to "10-x-y", please check out #24544

@codebytere codebytere mentioned this pull request Jul 20, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jul 20, 2020

@codebytere has manually backported this PR to "9-x-y", please check out #24648

@trop trop bot added the in-flight/9-x-y label Jul 20, 2020
@codebytere codebytere mentioned this pull request Jul 20, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Jul 20, 2020

@codebytere has manually backported this PR to "8-x-y", please check out #24649

georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
@codebytere @MarshallOfSound
fix: broken --trace-sync-io flag in Node.js (electron#24529)
e6d58d8
georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
@codebytere @MarshallOfSound
fix: broken --trace-sync-io flag in Node.js (electron#24529)
4240f20
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@codebytere @sentialx
fix: broken --trace-sync-io flag in Node.js (electron#24529)
62e5add
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
fix: broken --trace-sync-io flag in Node.js (electron#24529)
937894e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @jkleinsc @MarshallOfSound