Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pdf viewer template strings #24913

Merged
merged 1 commit into from
Aug 11, 2020
Merged

fix: pdf viewer template strings #24913

merged 1 commit into from
Aug 11, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 10, 2020 •
edited
Loading

Description of Change

Fixes broken i18n string templating in the PDF viewer extension.

Before:

before

After:
after

Sorry for the potato quality of these comparisons, its lowkey impossible to take a screenshot of something that requires hovering 😅

Checklist

Release Notes

Notes: Fixed broken toolbar hover text in the PDF viewer.

@codebytere codebytere requested review from nornagon and zcbenz August 10, 2020 03:57
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 10, 2020
nornagon
nornagon approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 11, 2020
@codebytere codebytere merged commit 7ded768 into master Aug 11, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 11, 2020

Release Notes Persisted

Fixed broken toolbar text in the PDF viewer.

@codebytere codebytere deleted the fix-print-i18n branch August 11, 2020 05:47
@trop
Copy link
Contributor

trop bot commented Aug 11, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@codebytere codebytere mentioned this pull request Aug 19, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Aug 19, 2020

@codebytere has manually backported this PR to "10-x-y", please check out #25047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@zcbenz zcbenz zcbenz approved these changes

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codebytere @nornagon @zcbenz @MarshallOfSound