-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calculate frame when setting window placement #25014
Conversation
This doesn't seem to fix #22440 , I thought it would be same codepath for both. |
e5d9e73
to
784f092
Compare
I confirm this PR does not fix it, I'll take a look at it too. |
784f092
to
1d88f73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
https://ci.appveyor.com/project/electron-bot/electron-ia32-testing/builds/34730405 is green, idk why it's still showing as pending. |
Release Notes Persisted
|
I was unable to backport this PR to "8-x-y" cleanly; |
I have automatically backported this PR to "10-x-y", please check out #25044 |
I have automatically backported this PR to "9-x-y", please check out #25045 |
Restoring windows from minimized state has been fixed But the bug is still there while restore from maximize state I am using Electron version 10.0.0 |
Description of Change
Close #22393.
When calling
SetWindowPlacement
, we should let Chromium handle theWM_NCCALCSIZE
message otherwise the window size would be wrong for frameless window.Checklist
npm test
passesRelease Notes
Notes: Fix frameless window's size being changed when restored from minimized state.