fix: prevent destroyed view references from causing crashes #25511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
6 tasks
|
@mlaurencin The backports need some fixes. |
Co-authored-by: Michaela Laurencin <laurencinmg@gmail.com>
codebytere
approved these changes
Sep 24, 2020
|
Release Notes Persisted
|
codebytere
deleted the
trop/10-x-y-bp-fix-prevent-destroyed-view-references-from-causing-crashes-1600301472125
branch
mlaurencin
pushed a commit
to mlaurencin/electron
that referenced
this pull request
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25411
Backport of #25146
See that PR for details.
Notes: Fixed crashes caused by attempting to modify destroyed views