Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent destroyed view references from causing crashes #25511

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 17, 2020

Backport of #25411
Backport of #25146

See that PR for details.

Notes: Fixed crashes caused by attempting to modify destroyed views

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 17, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 17, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 17, 2020
@zcbenz
Copy link
Member

zcbenz commented Sep 21, 2020

@mlaurencin The backports need some fixes.

@codebytere codebytere merged commit e964c1e into 10-x-y Sep 24, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 24, 2020

Release Notes Persisted

Fixed crashes caused by attempting to modify destroyed views

@codebytere codebytere deleted the trop/10-x-y-bp-fix-prevent-destroyed-view-references-from-causing-crashes-1600301472125 branch Sep 24, 2020
mlaurencin pushed a commit to mlaurencin/electron that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants