Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check printer list when no default printers #25606

Merged
merged 1 commit into from Sep 23, 2020

Conversation

codebytere
Copy link
Member

Backport of #25515

See that PR for details.

Notes: Fixed an issue where an error would be displayed when using webContents.print() if no default was set and no device name provided.

@codebytere codebytere requested a review from a team Sep 23, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 23, 2020
@codebytere codebytere merged commit 0b75053 into 10-x-y Sep 23, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 23, 2020

Release Notes Persisted

Fixed an issue where an error would be displayed when using webContents.print() if no default was set and no device name provided.

@codebytere codebytere deleted the check-printer-list-10 branch Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants