fix: wasm code generation in the renderer #25777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
commented
Oct 5, 2020
codebytere
force-pushed
the
wasm-cb-handler
branch
2 times, most recently
from
0c727b4 to
cf8b7b7
Compare
codebytere
force-pushed
the
wasm-cb-handler
branch
6 times, most recently
from
9f26ea0 to
2d17344
Compare
codebytere
force-pushed
the
wasm-cb-handler
branch
from
2d17344 to
c63b4ad
Compare
MarshallOfSound
approved these changes
Oct 8, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "10-x-y" cleanly; |
|
I have automatically backported this PR to "11-x-y", please check out #25829 |
3 tasks
|
@codebytere has manually backported this PR to "10-x-y", please check out #26063 |
ericmandel
added a commit
to ericmandel/js9
that referenced
this pull request
Oct 29, 2020
-- re-enable contextIsolation for version after that -- and make a versions array for future checks on versions -- references: -- electron/electron#26063 -- electron/electron#25777
pull bot
pushed a commit
to FairyWorld/tool_chromium
that referenced
this pull request
Oct 25, 2021
This CL exposes WasmCodeGenerationCheckCallbackInMainThread. This is done so that Electron can access this callback for customization purposes, as we need to use different handlers for different processes depending on whether or not we currently have access to Node.js. See electron/electron#25777 for a more thorough explanation. Change-Id: Ib697973e88028ebf1922e4afd6bf069fc6580584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527943 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#934533}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This CL exposes WasmCodeGenerationCheckCallbackInMainThread. This is done so that Electron can access this callback for customization purposes, as we need to use different handlers for different processes depending on whether or not we currently have access to Node.js. See electron/electron#25777 for a more thorough explanation. Change-Id: Ib697973e88028ebf1922e4afd6bf069fc6580584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527943 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#934533} NOKEYCHECK=True GitOrigin-RevId: 23a9b2d0ff5786bcf5d3ebd90b2b68380ed27158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #25127.
This issue arose from the fact that when
contextIsolationis enabled, Node.js does not have control over aspects of the context being used in the renderer process. It therefore goes to use its own callback handlers by default, but has not set embedder data for the context in question, and so when it pulls the data piece representing whether Wasm codegen should be enabled from the index it thinks such data will be at, this data piece is actually (don't ask)String.prototype.linkrepresented as av8::Function. We handle this by asking for the current Environment, and if none exists, we know that we're in the renderer withcontextIsolationenabled and should fall back to Blink's handler.cc @MarshallOfSound @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where Wasm code generation erroneously showed as being disallowed by embedder when
contextIsolationwas enabled.