Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close protocol response streams when aborted #26141

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 23, 2020

Backport of #24014

See that PR for details.

Notes: Protocol response streams are now destroyed if the request is aborted.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2020
@trop trop bot added 8-x-y backport This is a backport PR labels Oct 23, 2020
@miniak miniak force-pushed the miniak/streaming-protocol-early-close-8-x-y branch from 4082883 to 089c114 Compare October 23, 2020 22:35
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 23, 2020
@miniak miniak force-pushed the miniak/streaming-protocol-early-close-8-x-y branch from 089c114 to 657b1ec Compare October 24, 2020 00:52
@codebytere codebytere merged commit dd631c6 into 8-x-y Oct 26, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 26, 2020

Release Notes Persisted

Protocol response streams are now destroyed if the request is aborted.

@codebytere codebytere deleted the miniak/streaming-protocol-early-close-8-x-y branch October 26, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants