Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BrowserWindow.fromBrowserView in multiple-BrowserView windows #26493

Merged
merged 2 commits into from
Nov 17, 2020
Merged

fix: BrowserWindow.fromBrowserView in multiple-BrowserView windows #26493

merged 2 commits into from
Nov 17, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Nov 13, 2020 •
edited
Loading

Description of Change

Fixes #26488.

Checklist

Release Notes

Notes: Fixed BrowserWindow.fromBrowserView throwing an error when there were multiple BrowserViews in a window.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 13, 2020
codebytere
codebytere reviewed Nov 14, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test here? to at least ensure the exception is no longer thrown?

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 14, 2020
@nornagon nornagon merged commit 7c2ac6b into master Nov 17, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 17, 2020

Release Notes Persisted

Fixed BrowserWindow.fromBrowserView throwing an error when there were multiple BrowserViews in a window.

@nornagon nornagon deleted the nornagon-patch-1 branch November 17, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere left review comments

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BrowserWindow.fromBrowserView throws exception when there are multiple BrowserViews in a window
4 participants
@nornagon @ckerr @codebytere @MarshallOfSound