Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make setWindowButtonVisibility work for customButtonsOnHover #27073

Merged
merged 1 commit into from
Jan 19, 2021
Merged

fix: make setWindowButtonVisibility work for customButtonsOnHover #27073

merged 1 commit into from
Jan 19, 2021

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 18, 2020 •
edited
Loading

Description of Change

I have been cleaning up titleBarStyle's implementations and this is part of the refactoring. No one requested for this but it would be a good thing to fix an edge case in our APIs.

I have also added some tests for the setWindowButtonVisibility API.

Checklist

Release Notes

Notes: Make BrowserWindow.setWindowButtonVisibility work for window with customButtonsOnHover titlebar style.

@zcbenz zcbenz added the semver/patch backwards-compatible bug fixes label Dec 18, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 18, 2020
@zcbenz zcbenz added semver/minor backwards-compatible functionality and removed semver/patch backwards-compatible bug fixes labels Dec 18, 2020
@zcbenz zcbenz force-pushed the window-buttons-visibility branch from 53dee59 to 7aca1c5 Compare December 18, 2020 01:38
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 25, 2020
@zcbenz zcbenz changed the title feat: make setWindowButtonVisibility work for customButtonsOnHover fix: make setWindowButtonVisibility work for customButtonsOnHover Jan 19, 2021
@zcbenz zcbenz added semver/patch backwards-compatible bug fixes and removed api-review/requested 🗳 semver/minor backwards-compatible functionality labels Jan 19, 2021
@zcbenz zcbenz merged commit c3091c3 into master Jan 19, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 19, 2021

Release Notes Persisted

Make BrowserWindow.setWindowButtonVisibility work for window with customButtonsOnHover titlebar style.

@zcbenz zcbenz deleted the window-buttons-visibility branch January 19, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @codebytere