Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: suspend and resume are available on Linux #27958

Merged
merged 2 commits into from
Mar 5, 2021
Merged

docs: suspend and resume are available on Linux #27958

merged 2 commits into from
Mar 5, 2021

Conversation

efsiatras
Copy link
Contributor

Description of Change

Closes #27761.

Updates accordingly PowerMonitor documentation for suspend and resume, which were added on Linux by #25149.

Checklist

  • relevant documentation is changed or added

Release Notes

Notes: None

@welcome
Copy link

welcome bot commented Mar 2, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 2, 2021
@efsiatras efsiatras changed the title docs: suspend and resume are available on Linux #27761 docs: suspend and resume are available on Linux Mar 2, 2021
codebytere
codebytere previously approved these changes Mar 2, 2021
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codebytere codebytere dismissed their stale review March 2, 2021 17:40

meant to req changes, oops

docs/api/power-monitor.md Outdated Show resolved Hide resolved
docs/api/power-monitor.md Outdated Show resolved Hide resolved
@efsiatras efsiatras requested a review from codebytere March 2, 2021 18:23
@codebytere codebytere added documentation 📓 semver/patch backwards-compatible bug fixes labels Mar 3, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 3, 2021
@zcbenz zcbenz merged commit d92bab0 into electron:master Mar 5, 2021
@welcome
Copy link

welcome bot commented Mar 5, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Mar 5, 2021

Release Notes Persisted

None

@efsiatras efsiatras deleted the docs-updates branch March 12, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerMonitor incorrectly omits Linux for suspend, resume events
4 participants