-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: backport 3b21b6d from v8 to fix profiler crash #28531
Conversation
@indutny, looks like this patch needs another look
|
@ckerr ah, this is because the master branch uses V8 9.1.127 that is already fixed. I'll re-target this PR to 12-x-y. Sorry for the noise! |
@ckerr should be better now. PTAL |
Thank you @codebytere . Force pushed again. |
Sorry for a ping, but it'd be great if it could get into 12-x-y before the release (which apparently wasn't cut out just yet!) |
Release Notes Persisted
|
Awesome. Thanks! |
Description of Change
Fix: #28472
Release Notes
Notes: Fix crash when using profiler in devtools.