-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: potential crash when setting vibrancy #29677
Conversation
Build error due to unused variable after the change:
On line 1363 ( |
bf27332
to
7605bc8
Compare
49d8b7b
to
d615c69
Compare
Release Notes Persisted
|
I was unable to backport this PR to "12-x-y" cleanly; |
I have automatically backported this PR to "13-x-y", please check out #29722 |
I have automatically backported this PR to "14-x-y", please check out #29723 |
@codebytere has manually backported this PR to "12-x-y", please check out #30491 |
Description of Change
Closes #29653.
Fixes a potential crash when a value is passed in for the vibrancy type which is not valid either owing to operating system version or the string itself. This will now simply no-op.
Checklist
npm test
passesRelease Notes
Notes: Fixes a potential crash when setting vibrancy on macOS.