fix: broken OSR transparent option #32885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #32846.
Traced back to #30778 - we no longer have a transparent option in
webPreferences
, and soelectron/shell/browser/api/electron_api_web_contents.cc
Line 771 in 28ada6e
webPreferences
by propagating it towebPreferences
in theBrowserWindow
ctor:electron/shell/browser/api/electron_api_browser_window.cc
Lines 56 to 57 in 28ada6e
backgroundColor
being set to the hex equivalent ofSK_ColorTRANSPARENT
and proceed with that value.Tested with https://gist.github.com/29850810e9c5892587729d3d64a25761.
Checklist
npm test
passesRelease Notes
Notes: Fixed broken transparency option in offscreen window rendering.