fix: initialize FPS file in network service #33339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Mar 18, 2022
|
WOA test failure unrelated; everything else is green |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "18-x-y", please check out #33345 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A recent change in Chromium (CL: #3449280) now requires First Party Sets (FPS) to be fully initialized before queries can be received and responded to. This initialization happened in two parts: receiving the sets from the command line, and parsing the sets file.
This PR passes an empty file to
SetFirstPartySets, to allow both checks to pass.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where First Party Sets were not correctly loaded on app launch.