New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webContents: fix executejavascript when called before page load #5319

Merged

zcbenz merged 1 commit into electron:master from deepak1556:webcontents_executejavascript_patch

Apr 28, 2016

Member

deepak1556 commented Apr 27, 2016

The event parameter from did-finish-load was messing up the argument list.


          webContents: fix executejavascript when called before page load

4e6b148

Contributor

zcbenz commented Apr 28, 2016

Thanks!

zcbenz merged commit 6819278 into electron:master

bayleedev mentioned this pull request

Execute JavaScript doesn't work before window load. #5331

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet