Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: flags to control iwa enabled server whitelist #5638

Merged
merged 3 commits into from
May 23, 2016

Conversation

deepak1556
Copy link
Member

Since v0.37 there is no URLSecurityManager directly configured by brightray, instead we need to set the whitelist with HttpAuthPreferences. This makes app.allowNTLMCredentialsForAllDomains obsolete, have introduced flags which mimic chromes' behavior. This will be a breaking change. Also should DisableAuthNegotiateCnameLookup and EnableAuthNegotiatePort be added ?

Ref https://www.chromium.org/developers/design-documents/http-authentication

Fixes #4825

Depends on electron-archive/brightray#223

/cc @paulcbetts

@deepak1556
Copy link
Member Author

Actually could bring back app.AllowNTLMCredentialsForAllDomains by setting auth-server-whitelist=* internally, that way it wouldnt be breaking change. Thoughts ?

@anaisbetts
Copy link
Contributor

@deepak1556 This sounds good, we could just make the allowNTLMCredentialsForAllDomains just add command-line flags and require that you have to move it before ready

@deepak1556
Copy link
Member Author

Fixed, thanks!

@deepak1556 deepak1556 changed the title browser: flags to control iwa enabled server whitelist [WIP] browser: flags to control iwa enabled server whitelist May 23, 2016
@deepak1556 deepak1556 changed the title [WIP] browser: flags to control iwa enabled server whitelist browser: flags to control iwa enabled server whitelist May 23, 2016
@deepak1556
Copy link
Member Author

Have deprecated app.allowNTLMCredentialsForAllDomains and replaced with generic session.allowNTLMCredentialsForDomains. Not sure if this the right way to deprecate.

@zcbenz
Copy link
Contributor

zcbenz commented May 23, 2016

👍

@zcbenz zcbenz merged commit c489d6d into electron:master May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants