New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setFullscreen() on Windows #5718

Merged
merged 1 commit into from May 30, 2016

Conversation

Projects
None yet
2 participants
@felixrieseberg
Member

felixrieseberg commented May 26, 2016

This ensures that a BrowserWindow responds to setFullscreen(true) if full screenable was not defined during creation.

This bug was on Windows only. Previously, if you created a new BrowserWindow without specifying fullscreenable: true, setFullscreen(true) wouldn't do anything.

Closes #5699

@felixrieseberg felixrieseberg changed the title from :bug: Fix setFullscreen() on Windows to Fix setFullscreen() on Windows May 26, 2016

🐛 Fix setFullscreen() on Windows
This ensures that a BrowserWindow responds to `setFullscreen(true)` if
`full screenable` was not defined during creation.

This bug was on Windows only.
@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 30, 2016

👍

@zcbenz zcbenz merged commit ec53e49 into electron:master May 30, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment