Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the setTitleVisibility to control tittlebar's visibility #6097

Merged
merged 2 commits into from Jun 17, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Copy link
Member

zcbenz commented Jun 17, 2016

This continues #6089's work:

  • Fix titleBarStyle: 'hidden' showing title.
  • Make normal frameless window also show in Window menu.

@zcbenz zcbenz merged commit 0ccf49f into master Jun 17, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3464067 succeeded in 38s
Details
electron-linux-ia32 Build #3464068 succeeded in 33s
Details
electron-linux-x64 Build #3464069 succeeded in 122s
Details
electron-mas-x64 Build #1572 succeeded in 6 min 30 sec
Details
electron-osx-x64 Build #1578 succeeded in 6 min 30 sec
Details
electron-win-ia32 Build #576 succeeded in 6 min 17 sec
Details
electron-win-x64 Build #566 succeeded in 6 min 25 sec
Details

@zcbenz zcbenz deleted the should-set-tittle branch Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.