New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling Environment::GetCurrent for unjected contexts #6144

Merged
merged 1 commit into from Jun 20, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jun 20, 2016

It seems to cause crashes when it is called for contexts that do not have node integrations.

Close #6017.

Avoid calling Environment::GetCurrent for unjected contexts
It seems to cause crashes when it is called for contexts that do not
have node integrations.

@zcbenz zcbenz merged commit 6bd1a2d into master Jun 20, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3477807 succeeded in 41s
Details
electron-linux-ia32 Build #3477808 succeeded in 36s
Details
electron-linux-x64 Build #3477809 succeeded in 123s
Details
electron-mas-x64 Build #1613 succeeded in 5 min 42 sec
Details
electron-osx-x64 Build #1618 succeeded in 6 min 50 sec
Details
electron-win-ia32 Build #615 succeeded in 6 min 21 sec
Details
electron-win-x64 Build #609 succeeded in 6 min 27 sec
Details

@zcbenz zcbenz deleted the crash-release-renderer branch Jun 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment