Add <webview>.capturePage([rect,] callback) #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
changed the title
| kBGRA_8888_SkColorType); | ||
| } | ||
|
|
||
| void WebContents::OnCapturePageDone( |
There was a problem hiding this comment.
We can move this function to anonymous namespace since it does not actually need to use the members of WebContents.
kevinsawicki
force-pushed
the
webview-capture-page
branch
from
2b221f2 to
b900ff9
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the
capturePageimplementation from the window to the web contents so it can be used on a<webview>tag.Closes #3687