Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a getFeedURL API for the autoUpdater #6486

Merged
merged 6 commits into from
Jul 15, 2016
Merged

Add a getFeedURL API for the autoUpdater #6486

merged 6 commits into from
Jul 15, 2016

Conversation

MarshallOfSound
Copy link
Member

Implements the request getFeedURL API.

Closes #6454

kevinsawicki
kevinsawicki reviewed Jul 14, 2016
View reviewed changes
lib/browser/api/auto-updater/auto-updater-win.js
@@ -19,6 +19,10 @@ AutoUpdater.prototype.quitAndInstall = function () {
return app.quit()
}

AutoUpdater.prototype.GetFeedURL = function () {
Copy link
Contributor

@kevinsawicki kevinsawicki Jul 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be getFeedURL, lower case G

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops

@zcbenz
Copy link
Contributor

zcbenz commented Jul 15, 2016

👍

@zcbenz zcbenz merged commit 5db7582 into electron:master Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarshallOfSound @zcbenz @kevinsawicki