New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a getFeedURL API for the autoUpdater #6486

Merged
merged 6 commits into from Jul 15, 2016

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Member

MarshallOfSound commented Jul 14, 2016

Implements the request getFeedURL API.

Closes #6454

@@ -19,6 +19,10 @@ AutoUpdater.prototype.quitAndInstall = function () {
return app.quit()
}
AutoUpdater.prototype.GetFeedURL = function () {

This comment has been minimized.

@kevinsawicki

kevinsawicki Jul 14, 2016

Contributor

I think this should be getFeedURL, lower case G

This comment has been minimized.

@MarshallOfSound
@@ -109,6 +109,7 @@ void AutoUpdater::BuildPrototype(
v8::Isolate* isolate, v8::Local<v8::ObjectTemplate> prototype) {
mate::ObjectTemplateBuilder(isolate, prototype)
.SetMethod("checkForUpdates", &auto_updater::AutoUpdater::CheckForUpdates)
.SetMethod("getFeedURL", &auto_updater::AutoUpdater::GetFeedURL)

This comment has been minimized.

@kevinsawicki

kevinsawicki Jul 14, 2016

Contributor

Perhaps we should add an assert for this in spec/api-auto-updater-spec.js

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Jul 14, 2016

Member

@kevinsawicki The autoUpdater on macOS fails to setFeedURL when the application is unsigned. The test would only work for Windows I believe

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 15, 2016

👍

@zcbenz zcbenz merged commit 5db7582 into electron:master Jul 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment