New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not garbage collect sessions #6674

Merged
merged 3 commits into from Aug 1, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Aug 1, 2016

Since users can use partition strings to refer to Session objects, it is not usual for users to save a reference to Sessions. So we have to prevent Session from being garbaged collected, otherwise the same Session object might be deleted between uses of partition strings.

Close #6258.

zcbenz added some commits Aug 1, 2016

Remove usages of linked_ptr
It is no longer needed since we now have move semantic.

@zcbenz zcbenz merged commit d56057b into master Aug 1, 2016

4 of 6 checks passed

electron-win-x64 Build #1053 failed in 6 min 34 sec
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3737563 succeeded in 54s
Details
electron-linux-ia32 Build #3737564 succeeded in 47s
Details
electron-linux-x64 Build #3737565 succeeded in 81s
Details
electron-win-ia32 Build #1070 succeeded in 6 min 32 sec
Details

@zcbenz zcbenz deleted the session-no-gc branch Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment