New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe back/forward should respect system preferences #6686

Merged
merged 2 commits into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@darkdh
Contributor

darkdh commented Aug 2, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 2, 2016

Theses events are not always used for swiping back/forward, for example in N1 it is used for archiving emails (#4181). So I think a more flexible way is to expose an systemPreferences.isSwipeTrackingFromScrollEventsEnabled() API, and Brave browser can use it to decide the behavior.

@darkdh

This comment has been minimized.

Contributor

darkdh commented Aug 3, 2016

Thanks for the advice, @zcbenz. I've put it in e0c0e3e

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 3, 2016

👍

@zcbenz zcbenz merged commit 322fb97 into electron:master Aug 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@darkdh darkdh deleted the darkdh:swipe_prefs branch Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment