Configure ink drops on menu bar buttons #7397

merged 3 commits into from Sep 29, 2016


None yet

2 participants

kevinsawicki commented Sep 28, 2016 edited

The 1.4 upgrade to Chrome 53 caused the menu bar buttons to no longer show hover/click states on Windows and Linux.

This pull request updates them to use the new ink drop effects that Chrome now uses for buttons to show feedback for press and hover.

Windows Ubuntu
screen shot 2016-09-28 at 3 29 23 pm screen shot 2016-09-28 at 3 26 18 pm

Closes #7279

@kevinsawicki kevinsawicki changed the title from Configure ink drops on menu bar button to Configure ink drops on menu bar buttons Sep 28, 2016
zcbenz commented Sep 29, 2016

There are a few cpplint warnings, other parts are good to me.

kevinsawicki added some commits Sep 28, 2016
@kevinsawicki @kevinsawicki kevinsawicki Add ink drop to menu bar buttons eeecca6
@kevinsawicki @kevinsawicki kevinsawicki Pass background color to submenu button ed1c10f
@kevinsawicki kevinsawicki Sort includes
@kevinsawicki kevinsawicki merged commit b3b9994 into master Sep 29, 2016

0 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
electron-linux-arm Build #4282056 started
electron-linux-ia32 Build #4282057 queued
electron-linux-x64 Build #4282058 queued
@kevinsawicki kevinsawicki deleted the ink-drop-on-system-menu branch Sep 29, 2016
@aluxian-huginn aluxian-huginn referenced this pull request in Aluxian/Messenger-for-Desktop Sep 30, 2016

Update dependency: electron v1.4.2 #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment