New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use firstObject instead of objectAtIndex:0 #8249

Merged
merged 1 commit into from Dec 21, 2016

Conversation

Projects
None yet
1 participant
@kevinsawicki
Contributor

kevinsawicki commented Dec 20, 2016

Same approach as upstream Chrome uses since [NSScreens screens] can be empty at time.

https://codereview.chromium.org/1380083005

Closes #8064

@kevinsawicki kevinsawicki merged commit 026711e into master Dec 21, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #5015183 succeeded in 62s
Details
electron-linux-ia32 Build #5015184 succeeded in 61s
Details
electron-linux-x64 Build #5015185 succeeded in 130s
Details
electron-mas-x64 Build #3058 succeeded in 7 min 53 sec
Details
electron-osx-x64 Build #3068 succeeded in 8 min 35 sec
Details
electron-win-ia32 Build #2116 succeeded in 12 min
Details
electron-win-x64 Build #2099 succeeded in 12 min
Details

@kevinsawicki kevinsawicki deleted the nsscreens-crash branch Dec 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment