Don't load URL if web contents is destroyed #8254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
webcontents-will-navigate-crash
branch
3 times, most recently
from
9e76ac1 to
f1668b8
Compare
kevinsawicki
force-pushed
the
webcontents-will-navigate-crash
branch
from
f1668b8 to
abea119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing a window from a
will-navigatelistener but not callingevent.preventDefault()would crash the app because the URL would continue to load in a destroyed web contents.This adds a check to see if the web contents was marked as destroyed after the
will-navigateevent is emitted.Closes #4374