Feature/macOS relative window levels #8487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [window_ setLevel:windowLevel]; | ||
|
|
||
| NSInteger newLevel = windowLevel + relativeLevel; | ||
| if (newLevel >= 0 && newLevel < CGWindowLevelForKey(kCGMaximumWindowLevelKey)) { |
There was a problem hiding this comment.
Not a big fan of silent fallbacks. Ideally it should throw when I'm giving it invalid values, like above CGWindowLevelForKey(kCGMaximumWindowLevelKey), so I would know I'm doing something wrong.
There was a problem hiding this comment.
Yeah, I agree, the new level being out of range should throw an error.
| window_->SetAlwaysOnTop(top, level, relativeLevel, &error); | ||
|
|
||
| if (!error.empty()) { | ||
| args->ThrowError(error); |
There was a problem hiding this comment.
Can you add a spec that asserts this error is thrown for invalid relative levels?
|
|
||
| NSInteger newLevel = windowLevel + relativeLevel; | ||
|
|
||
| if (newLevel >= 0 && newLevel <= maxWindowLevel) { |
There was a problem hiding this comment.
Looks like there is a kCGMinimumWindowLevelKey, maybe that would be better to use than 0 here?
|
Thanks for this @leethomas 👍 🚢 |
|
Amazing, will help a lot on Kap! Thank you @leethomas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to implement #8153. I don't have a test for it because then I'd have to expose the getter for
levelto verify that the levels were taken into account which would feel like a strange thing to do for just a test, unless you guys think it should be in the API.