Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating BrowerWindows with a parent always makes them show #8836

Closed
kirkouimet opened this issue Mar 4, 2017 · 4 comments · Fixed by #9343
Closed

Creating BrowerWindows with a parent always makes them show #8836

kirkouimet opened this issue Mar 4, 2017 · 4 comments · Fixed by #9343

Comments

@kirkouimet
Copy link
Contributor

kirkouimet commented Mar 4, 2017

  • Electron version: 1.6.1
  • Operating system: macOS Sierra

When you do this from a renderer process:

new electron.remote.BrowserWindow(
    parent: parentBrowserWindow,
    show: false,
);

The browser window always shows even though the show option is false. If you do not provide a parent, the browser window respects the show option.

@kirkouimet kirkouimet changed the title Creating BrowerWindow's with a parent always makes them show Creating BrowerWindows with a parent always makes them show Mar 4, 2017
@xaviergonz
Copy link
Contributor

xaviergonz commented Apr 28, 2017

Just adding to this, it happened to me when modal was false under osx. Did not test windows

@ionphractal
Copy link

'ready-to-show' is also not triggered.
It works properly for me under Windows and Linux.

@xaviergonz
Copy link
Contributor

xaviergonz commented May 1, 2017

@kevinsawicki just created a pull request to fix this issue
#9343

I used this repo to test it works ok:
https://github.com/xaviergonz/electron-quick-start

@xaviergonz
Copy link
Contributor

PS: It also fixes a bug where if a child window is hidden and then re-shown it looses its child window status.

zcbenz added a commit that referenced this issue Sep 14, 2017
Make OSX child windows honor the show option to fix #8836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants