New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default menu items for 'Edit' and 'Window' #2814 #8880

Merged
merged 6 commits into from Mar 29, 2017

Conversation

Projects
None yet
2 participants
@mst128256
Contributor

mst128256 commented Mar 9, 2017

New roles menuEdit and menuWindow were added to layout a kind of default Edit and Window submenu to the top menu bar. If there is a submenu in the item, default layout do not apply. Layout slightly differs for MacOS and Windows.

Closes #2814

mst128256 added some commits Mar 9, 2017

@kevinsawicki

Left a few minor comments, thanks for implementing this.

Show outdated Hide outdated docs/api/menu-item.md
Show outdated Hide outdated docs/api/menu-item.md
@@ -11,7 +11,7 @@ const MenuItem = function (options) {
for (let key in options) {
if (!(key in this)) this[key] = options[key]
}
this.submenu = this.submenu || roles.getDefaultSubmenu(this.role)

This comment has been minimized.

@kevinsawicki

kevinsawicki Mar 16, 2017

Contributor

Can you add a spec for these new cases in the https://github.com/electron/electron/blob/master/spec/api-menu-spec.js#L424 block?

@kevinsawicki

This comment has been minimized.

@mst128256

mst128256 Mar 24, 2017

Contributor

Added - please check next commits.

@mst128256

mst128256 Mar 24, 2017

Contributor

Added - please check next commits.

@kevinsawicki kevinsawicki self-assigned this Mar 17, 2017

mst128256 added some commits Mar 24, 2017

@kevinsawicki kevinsawicki merged commit 57edc28 into electron:master Mar 29, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Mar 29, 2017

Contributor

Thanks for this, pushed one minor commit that tweaked the formatting a bit 🚀 🎸

Contributor

kevinsawicki commented Mar 29, 2017

Thanks for this, pushed one minor commit that tweaked the formatting a bit 🚀 🎸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment