Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Add freetype 2.8.1 patch #387

Merged
merged 2 commits into from
Dec 28, 2017
Merged

Add freetype 2.8.1 patch #387

merged 2 commits into from
Dec 28, 2017

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Nov 8, 2017

Fixes #384

@MarshallOfSound
Copy link
Member Author

@alexeykuzmin When this is merged it can be deleted in the chromium 61 branch (this patch is in chromium 61+)

@alexeykuzmin
Copy link
Contributor

@MarshallOfSound 👍

@alexeykuzmin
Copy link
Contributor

@MarshallOfSound Should it be merged? All the checks seem to be fine.

@MarshallOfSound
Copy link
Member Author

@alexeykuzmin Yeah, if someone approves all 3 PR's we can merge them in 👍

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but do we have a preferred way -- eg filing open issues -- of leaving breadcrumbs to remind us to remove this-or-that patch when we get an upstream fix?

@alexeykuzmin
Copy link
Contributor

@ckerr If a patch just backports something from a newer version as is,
it will simply fail when we try to apply it to that version. It actually happens almost every Chromium and Node.js upgrade.
But if a patch is a temporary workaround, I would prefer to have an open issue to remove it when it's no longer needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants