Rename version-string option to win32metadata #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
force-pushed
the
win32metadata-option
branch
from
ba1d8b8
to
bcb1c4f
Compare
malept
force-pushed
the
win32metadata-option
branch
from
bcb1c4f
to
5c0cbf6
Compare
malept
force-pushed
the
win32metadata-option
branch
from
5c0cbf6
to
c6c145d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Summarize your changes:
Deprecates
version-stringin favor ofwin32metadata.version-stringwill be removed in a future major version.Fixes #331.
Are your changes appropriately documented?
Updated NEWS, API, & CLI docs.
Do your changes have sufficient test coverage?
Yes
Does the testsuite pass successfully on your local machine?
Yes