Fix issues #5 (compilation error with no MFC) and #6 (truncation of version fields to 8 bits) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2016 16:02
rcedit.rc has #include "afxres.h" but this file is not present when Visual Studio was installed without the MFC option. rcedit does not actually use MFC, so the fix is simply to #include <windows.h> instead.
These fields are actually 16 bits.
|
👍 |
This was referenced Jan 30, 2016
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes these two issues:
#5: Compilation fails with error RC1015 when MFC was not installed with Visual Studio
#6: File version and product version fields are erroneously truncated to 8 bits