Skip to content

fix: overzealous EventEmitter typings #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019
+24 −12
Merged

fix: overzealous EventEmitter typings #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,18 +198,30 @@ export const paramify = (paramName: string) => {
};
// TODO: Infer through electron-docs-linter/parser
export const isEmitter = (module: Pick<ModuleDocumentationContainer, 'name'>) => {
switch (module.name.toLowerCase()) {
case 'menu':
case 'menuitem':
case 'nativeimage':
case 'shell':
case 'crashreporter':
case 'dock':
case 'commandline':
return false;
default:
return true;
}
const nonEventEmitters = [
'menu',
'menuitem',
'nativeimage',
'shell',
'browserview',
'webrequest',
'crashreporter',
'dock',
'commandline',
'browserwindowproxy',
'clipboard',
'contenttracing',
'desktopcapturer',
'dialog',
'globalshortcut',
'powersaveblocker',
'touchbar',
'touchbarbutton',
'net',
'netlog',
'protocol'
];
return !(nonEventEmitters.includes(module.name.toLowerCase()))
};
export const isPrimitive = (type: string) => {
const primitives = ['boolean', 'number', 'any', 'string', 'void', 'unknown'];
Expand Down