Webview linting fixes #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on electron/electron#9012 and electron/electron-docs-linter#89 |
|
Merged electron/electron#9012 Merged electron/electron-docs-linter#89, released 2.2.0, and updated this PR to use the newer linter version. |
|
@zeke Haha, things keep breaking whenever I update the Electron commit hash 😢 electron/electron-docs-linter#90 Moving goalposts 😆 |
|
☝️ Shipped those two things and restarted the Travis builds |
|
Tests doing weird things, will looking into the ENOTFOUND errors |
|
Bump. Let me know if you want me to take over on this PR. :) |
MarshallOfSound
force-pushed
the
webview-linting-fixes
branch
from
63ab779 to
f47ab20
Compare
|
Once electron/electron-docs-linter#92 and electron/electron#9080 get merged there are 0 linting errors 👍 /cc @zeke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whole bunch of fixes in here, mostly to do with linting output, webview implementation and NodeJS overrides
/cc @zeke
Depends on PR's in electron/electron and electron/electron-docs-linter